[KCMs/Night Color] Remove "manual location entry" mode
AbandonedPublic

Authored by ngraham on Dec 12 2019, 3:30 PM.

Details

Reviewers
davidedmundson
Group Reviewers
VDG
Plasma
Summary

This mode allows you to set Night Color to trigger based on the sunset/sunrise times of an
arbitrary latitude/longitude location. However this is completely pointless; there is no
conceivable use case for setting the location to any place other than your current
location. The only reason why you would want to enter your current location manually is
if the automatic geolocation feature is broken. However if this is the case, it is much
faster to just enter start/end times manually than it is to look up your latitude and
longitude and enter them into the text fields here.

Therefore, this patch removes that mode from the KCM and requires that people who don't
use the automatic geolocation feature enter the start/end times manually.

In the future, we could even remove the geolocator and base the location on the current
time zone so we can bypass failures of the geolocator.

Test Plan

Modes now:

Diff Detail

Repository
R119 Plasma Desktop
Branch
remove-manual-location-entry-mode (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19753
Build 19771: arc lint + arc unit
ngraham created this revision.Dec 12 2019, 3:30 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 12 2019, 3:30 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Dec 12 2019, 3:30 PM
ngraham edited the test plan for this revision. (Show Details)Dec 12 2019, 3:30 PM
zzag added a subscriber: zzag.Dec 12 2019, 3:35 PM

-1

This mode can be useful for people concerned about privacy.

ngraham abandoned this revision.Dec 12 2019, 3:45 PM

Vlad and I talked in person and he convinced me that this was a bad idea.