Differential D25914

Remove ColorSchemeFilter from KStyle
ClosedPublic
Actions

Authored by davidre on Dec 12 2019, 10:24 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Frameworks
Commits
R252:9fc5bade9c26: Remove ColorSchemeFilter from KStyle
Summary

The code is duplciated in plasma-integration. According to the summary of
e47245f96ed1f7decc7209eafe969889579b1c38 when it was added to plasma-integration
it could/should have been removed.

Test Plan

When changing color scheme the titlebar color still changes

Diff Detail

Repository
R252 Framework Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidre created this revision.Dec 12 2019, 10:24 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 12 2019, 10:24 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidre requested review of this revision.Dec 12 2019, 10:24 AM
davidedmundson accepted this revision.Dec 12 2019, 10:31 AM
This revision is now accepted and ready to land.Dec 12 2019, 10:31 AM
Closed by commit R252:9fc5bade9c26: Remove ColorSchemeFilter from KStyle (authored by davidre). · Explain WhyDec 12 2019, 10:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kstyle/kstyle.cpp (75 lines)

Diff 71344

View Options

src/kstyle/kstyle.cpp

Loading...