Differential D25887

[ColorScope] Work with plain QObjects again
ClosedPublic
Actions

Authored by broulik on Dec 11 2019, 3:00 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R242:8f7b2c9ae099: [ColorScope] Work with plain QObjects again
Summary

Otherwise colorScope doesn't attach to things like Plasma.Svg.
Also remove superfluous cast as parentItem() returns a QQuickItem *.

Test Plan
  • Battery on lock screen gets proper complementary color group again
  • didn't actually test the applet background stuff that this change was originally made for

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 11 2019, 3:00 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 11 2019, 3:00 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Dec 11 2019, 3:00 PM
mart accepted this revision.Dec 11 2019, 3:01 PM
This revision is now accepted and ready to land.Dec 11 2019, 3:01 PM
Closed by commit R242:8f7b2c9ae099: [ColorScope] Work with plain QObjects again (authored by broulik). · Explain WhyDec 11 2019, 3:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 71281

View Options

src/declarativeimports/core/colorscope.cpp

Loading...