Refactor GTK KCM code
ClosedPublic

Authored by gikari on Dec 11 2019, 8:46 AM.

Details

Summary

This diff introduces purely cosmetic changes.

  1. KCM now compiled with no signals/slot keywords to avoid clash with gtk
  2. Remove linking of XCursors library, because it is no longer needed
  3. Replace some for-cycles with range-based ones
  4. Wrap some string literals with QStringLiteral
  5. Rearrange include headers
  6. Some other changes to better match code style
Test Plan

Check, if there is no regressions

Diff Detail

Repository
R99 KDE Gtk Configuration Tool
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gikari created this revision.Dec 11 2019, 8:46 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 11 2019, 8:46 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gikari requested review of this revision.Dec 11 2019, 8:46 AM
apol accepted this revision.Dec 18 2019, 4:47 PM
This revision is now accepted and ready to land.Dec 18 2019, 4:47 PM
This revision was automatically updated to reflect the committed changes.