[kcmkwin/compositing] Hide config options which don't make sense if Compositing is required
ClosedPublic

Authored by graesslin on Aug 26 2016, 11:00 AM.

Details

Summary

On Wayland compositing is required. It doesn't make any sense to offer
the user to disable the compositor or to allow windows to block
compositing.

The Compositor DBus interface gains a new property whether the platform
requires compositing. This is queried by the compositing kcm and based
on that the two mentioned options get hidden and not stored to config
file.

Test Plan

Opened the KCM on Wayland

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 6289.Aug 26 2016, 11:00 AM
graesslin retitled this revision from to [kcmkwin/compositing] Hide config options which don't make sense if Compositing is required.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptAug 26 2016, 11:00 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
sebas added a subscriber: sebas.Sep 12 2016, 8:04 PM
sebas added inline comments.
dbusinterface.h
118

same name for property and READ accessor?

kcmkwin/kwincompositing/compositing.h
50

again, same name instead of using 3 different variations

graesslin marked 2 inline comments as done.Sep 13 2016, 8:08 AM
graesslin updated this revision to Diff 6681.Sep 13 2016, 8:10 AM

Adjusted naming as suggested

sebas accepted this revision.Sep 13 2016, 12:47 PM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Sep 13 2016, 12:47 PM
This revision was automatically updated to reflect the committed changes.