Differential D25786

[nightcolor] Introduce inhibition API
ClosedPublic
Actions

Authored by zzag on Dec 6 2019, 3:27 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:5bec89ac90d5: [nightcolor] Introduce inhibition API
Summary

The new API allows to block Night Color temporarily. This can be useful
for applications such as video games and plasma applets.

CCBUG: 400418

Test Plan

Called inhibit() and uninhibit() from D-Feet.

Diff Detail

Repository
R108 KWin
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 19755
Build 19773: arc lint + arc unit
zzag created this revision.Dec 6 2019, 3:27 PM
Restricted Application added a project: KWin. · View Herald TranscriptDec 6 2019, 3:27 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Dec 6 2019, 3:27 PM
zzag updated this revision to Diff 71021.Dec 6 2019, 3:31 PM

Actually we don't need showStatusOsd() anymore.

zzag updated this revision to Diff 71368.Dec 12 2019, 4:12 PM

Use correct object path for PropertiesChanged signal.

zzag updated this revision to Diff 71427.Dec 13 2019, 1:17 PM

Minor updates.

zzag updated this revision to Diff 71436.Dec 13 2019, 1:33 PM

Rename m_isInhibited to m_isGloballyInhibited, fix a typo in m_inhibitReferenceCount.

zzag updated this revision to Diff 72872.Jan 6 2020, 12:19 PM

Don't use deprecated QMultiHash::insertMulti().

davidedmundson accepted this revision.Jan 7 2020, 12:47 PM
This revision is now accepted and ready to land.Jan 7 2020, 12:47 PM
Closed by commit R108:5bec89ac90d5: [nightcolor] Introduce inhibition API (authored by zzag). · Explain WhyJan 7 2020, 3:13 PM
This revision was automatically updated to reflect the committed changes.
victorr added a subscriber: victorr.Jan 12 2020, 3:08 PM

No translation to on-screen switch sensor.
You need to apply the attached patch.

kwin-5.17.80-fix.patch536 BDownload

Before:


After:

zzag added a comment.Jan 12 2020, 3:51 PM

@victorr Can you provide your real name and email for the authorsihp information? I'll push the patch on your behalf.

victorr added a comment.Jan 12 2020, 4:30 PM

https://phabricator.kde.org/p/victorr/
victorr (Victor Ryzhykh)
Volunteer RosaLab aka VictorR2007
victorr2007@yandex.ru

zzag added a comment.Jan 12 2020, 7:31 PM
In D25786#592620, @victorr wrote:

https://phabricator.kde.org/p/victorr/
victorr (Victor Ryzhykh)
Volunteer RosaLab aka VictorR2007
victorr2007@yandex.ru

Thanks.

Showing Only Differences

This revision modifies 4 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 71368

View Options

colorcorrection/colorcorrectdbusinterface.cpp

Loading...