[Notifications] Add draggable file icon when single file job finishes

Authored by broulik on Dec 6 2019, 11:56 AM.



This adds a file icon to a finished job for a single total file which can be dragged anywhere for convenience.

Test Plan

Often I download a file and then want to send it to someone, so being able to drag it off the notification similar to how you can do it with the screenshot notification is super useful.

The button glows on hover and has the open hand cursor to indicate it can be dragged

Clicking it opens the file and right click opens a file context menu. It is kinda redundant with the "Open" and menu button but I think something that looks like a file should be have like a file and those visual actions should be kept for accessibility.

Diff Detail

R120 Plasma Workspace
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 6 2019, 11:56 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 6 2019, 11:56 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 6 2019, 11:56 AM
ngraham added a subscriber: ngraham.Dec 6 2019, 1:58 PM

Awesome, this is super-dee-duper useful! +1!


maybe use one of the standard sizes instead of a hardcoded int?

ngraham accepted this revision as: VDG.Dec 6 2019, 1:58 PM
broulik added inline comments.Dec 6 2019, 2:00 PM

That's the default, there's a Binding to units.iconSizes.large in main.qml

This revision was not accepted when it landed; it landed in state Needs Review.Dec 18 2019, 10:35 AM
This revision was automatically updated to reflect the committed changes.