Replace KPassivePopup with KNotification (#346354)
AcceptedPublic

Authored by azamathackimov on Dec 5 2019, 7:34 PM.

Diff Detail

Repository
R456 Lokalize
Lint
Lint Skipped
Unit
Unit Tests Skipped
azamathackimov requested review of this revision.Dec 5 2019, 7:34 PM
azamathackimov created this revision.
broulik added a subscriber: broulik.Dec 5 2019, 9:38 PM

I don't know what the UI looks like or what workflow it serves but judging from the fact it's a QDockWidget I assume a KMessageWidget inside the dock would be more fitting than a free-floating notification?

I don't know what the UI looks like or what workflow it serves but judging from the fact it's a QDockWidget I assume a KMessageWidget inside the dock would be more fitting than a free-floating notification?

It’s a QDockWidget, yes, but that’s the point, a QDockWidget was used in a context where a systray notification was more fitting.

Notice that, while the code is in a view, the action is triggered from an application-wide menu.

Maybe KMessageWidget within the main UI component (the view of the source and target strings) would make sense…

The current HIG suggest a progress bar for these scenarios (https://hig.kde.org/components/assistance/progress.html), but I’m not sure where that would go in Lokalize, and it would definitely require more complex changes.

I’m +1 to this patch as long as it works (I’m hoping to check for myself soon), as even if the solution may not be the ideal one it is an improvement over the current state of things.

This revision is now accepted and ready to land.Sat, Jan 11, 9:33 PM