Differential D25749

[CopyJob] When linking also consider https for text-html icon
ClosedPublic
Actions

Authored by broulik on Dec 4 2019, 7:14 PM.

Details

Reviewers
ngraham
Group Reviewers
Frameworks
Commits
R241:b78027f01176: [CopyJob] When linking also consider https for text-html icon
Summary

Ensures dragging a "https" link, which is most of them these days, has a proper icon.

Test Plan
  • Dragged a link on a website to my desktop, chose "link", got a desktop file with proper icon created

In a later step this should probably be ported to use KProtocolInfo::icon since http KIO slave has text-html as icon and ftp has folder-remote. Could simplify the if condition a bit.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 4 2019, 7:14 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 4 2019, 7:14 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Dec 4 2019, 7:14 PM
broulik edited the test plan for this revision. (Show Details)Dec 4 2019, 7:24 PM
ngraham accepted this revision.Dec 4 2019, 7:28 PM
This revision is now accepted and ready to land.Dec 4 2019, 7:28 PM
Closed by commit R241:b78027f01176: [CopyJob] When linking also consider https for text-html icon (authored by broulik). · Explain WhyDec 4 2019, 7:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/copyjob.cpp (2 lines)

Diff 70919

View Options

src/core/copyjob.cpp

Loading...