[QImageItem/QPixmapItem] Don't lose precision during calculation
AcceptedPublic

Authored by broulik on Mon, Dec 2, 3:02 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Summary

Operate on QRectF/QSizeF and only round back to integer at the end.

Test Plan

I've always been under the impression that the previews in icons kcm were misaligned or cut off slightly.
Before


After

  • Notification thumbnail strip (qpixmapitem) still works
  • QR code in klipper (qimageitem) still works

Diff Detail

Repository
R296 KDeclarative
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mon, Dec 2, 3:02 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMon, Dec 2, 3:02 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Mon, Dec 2, 3:02 PM
davidedmundson accepted this revision.Tue, Dec 10, 9:40 PM
This revision is now accepted and ready to land.Tue, Dec 10, 9:40 PM