Differential D25666

Port away from overloaded KCModule signal
ClosedPublic
Actions

Authored by davidedmundson on Dec 1 2019, 10:11 PM.

Tags

Subscribers

Details

Reviewers

apol
zzag

Group Reviewers

Commits

R108:f45ad69c78d5: Port away from overloaded KCModule signal

Test Plan

Compiles

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson created this revision.Dec 1 2019, 10:11 PM

Restricted Application added a project: KWin. · View Herald TranscriptDec 1 2019, 10:11 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

davidedmundson requested review of this revision.Dec 1 2019, 10:11 PM

Harbormaster completed remote builds in B19358: Diff 70699.Dec 1 2019, 10:11 PM

stupid arc

Harbormaster completed remote builds in B19359: Diff 70700.Dec 1 2019, 10:12 PM

apol accepted this revision.Dec 2 2019, 3:18 AM

This revision is now accepted and ready to land.Dec 2 2019, 3:18 AM

When was KCModule::markAsChanged introduced?

Nvm, 5.64.

Closed by commit R108:f45ad69c78d5: Port away from overloaded KCModule signal (authored by davidedmundson). · Explain WhyDec 2 2019, 9:05 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			effects/desktopgrid/desktopgrid_config.cpp (4 lines)
M			effects/mouseclick/mouseclick_config.cpp (2 lines)
M			effects/presentwindows/presentwindows_config.cpp (2 lines)
M			effects/thumbnailaside/thumbnailaside_config.cpp (2 lines)
M			effects/zoom/zoom_config.cpp (2 lines)
M			kcmkwin/kwincompositing/main.cpp (2 lines)

Diff 70728

effects/desktopgrid/desktopgrid_config.cpp

Loading...

effects/mouseclick/mouseclick_config.cpp

Loading...

effects/presentwindows/presentwindows_config.cpp

Loading...

effects/thumbnailaside/thumbnailaside_config.cpp

Loading...

effects/zoom/zoom_config.cpp

Loading...

kcmkwin/kwincompositing/main.cpp

Loading...