Differential D25636

Fixup deprecated use of QWeakPointer::data
ClosedPublic
Actions

Authored by davidedmundson on Nov 30 2019, 6:08 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R129:a2851338b3d6: Fixup deprecated use of QWeakPointer::data
Summary

At the point init is run we can be sure that our decoration->client()
pointer is valid, but we still need to get a strongRef for the duration
of our usage for Qt6

Test Plan

Compiles

Diff Detail

Repository
R129 Window Decoration Library
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19312
Build 19330: arc lint + arc unit
davidedmundson created this revision.Nov 30 2019, 6:08 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 30 2019, 6:08 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Nov 30 2019, 6:08 PM
apol accepted this revision.Nov 30 2019, 7:07 PM
This revision is now accepted and ready to land.Nov 30 2019, 7:07 PM
Closed by commit R129:a2851338b3d6: Fixup deprecated use of QWeakPointer::data (authored by davidedmundson). · Explain WhyDec 1 2019, 12:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/decorationbutton.cpp (4 lines)

Diff 70629

View Options

src/decorationbutton.cpp

Loading...