[System Tray] Clean up popup code
ClosedPublic

Authored by filipf on Fri, Nov 29, 3:17 PM.

Details

Summary

This removes hacks and does things in a cleaner way.

Credits go to @broulik.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Fri, Nov 29, 3:17 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Nov 29, 3:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Fri, Nov 29, 3:17 PM
This comment was removed by filipf.
ngraham added inline comments.
applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
103

onToggled?

filipf added inline comments.Mon, Dec 2, 10:16 AM
applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
103
broulik added inline comments.Mon, Dec 2, 10:17 AM
applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
103

Both are fine I guess but onToggled is indeed more correct

filipf updated this revision to Diff 70748.Mon, Dec 2, 1:45 PM

onToggled instead of onClicked

filipf marked 3 inline comments as done.Mon, Dec 2, 1:46 PM
ngraham accepted this revision.Mon, Dec 2, 2:41 PM
This revision is now accepted and ready to land.Mon, Dec 2, 2:41 PM
This revision was automatically updated to reflect the committed changes.