Differential D25577

Destroy dmabuf implementation on EGL backend going down
ClosedPublic
Actions

Authored by romangg on Nov 27 2019, 7:46 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:e2d5ec606a39: Destroy dmabuf implementation on EGL backend going down
Summary

We leak memory if we do not destroy the dmabuf implementation on EGL backend
going down.

Also this makes sure everything is cleaned up on shutdown.

FIXED-IN: 5.17.4

BUG: 413637

Test Plan

Compiles, settings change and shutdown ok.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Nov 27 2019, 7:46 PM
Restricted Application added a project: KWin. · View Herald TranscriptNov 27 2019, 7:46 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
romangg requested review of this revision.Nov 27 2019, 7:46 PM
romangg edited the summary of this revision. (Show Details)Nov 27 2019, 8:05 PM
davidedmundson accepted this revision.Nov 27 2019, 8:09 PM
davidedmundson added a subscriber: davidedmundson.

Maybe also consider QScopedPointer

This revision is now accepted and ready to land.Nov 27 2019, 8:09 PM
romangg edited the summary of this revision. (Show Details)Nov 30 2019, 2:46 PM
Closed by commit R108:e2d5ec606a39: Destroy dmabuf implementation on EGL backend going down (authored by romangg). · Explain WhyNov 30 2019, 2:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 70618

View Options

linux_dmabuf.h

Loading...
View Options

platformsupport/scenes/opengl/abstract_egl_backend.h

Loading...
View Options

platformsupport/scenes/opengl/abstract_egl_backend.cpp

Loading...
View Options

platformsupport/scenes/opengl/egl_dmabuf.h

Loading...