[kfinddialog] Remove usage of kregexpeditor plugin system
ClosedPublic

Authored by nicolasfella on Nov 26 2019, 12:51 AM.

Details

Summary

The interface is only provided by one unreleased application, so people are used to use the fallback implementation.
This allows to drop the dependency on KService

Test Plan

Test KFindDialog with KAlarm

Diff Detail

Repository
R310 KTextWidgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Nov 26 2019, 12:51 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 26 2019, 12:51 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Nov 26 2019, 12:51 AM
cullmann requested changes to this revision.Nov 26 2019, 5:52 PM
cullmann added a subscriber: cullmann.

Looks good in principle.

Could we not at least remove

install( FILES kregexpeditor/kregexpeditor.desktop DESTINATION ${KDE_INSTALL_KSERVICETYPES5DIR} )

too?
We need to keep the header to have the application compiling, but the desktop file can go away now, or?

Beside that, should the header not get a deprecation attribute to ensure nobody new picks that up?

This revision now requires changes to proceed.Nov 26 2019, 5:52 PM
  • [kfinddialog] Remove usage of kregexpeditor plugin system
  • Remove desktop file

Beside that, should the header not get a deprecation attribute to ensure nobody new picks that up?

yes, one step at a time :)

cullmann accepted this revision.Nov 26 2019, 6:01 PM

Ok ,=)

This revision is now accepted and ready to land.Nov 26 2019, 6:01 PM
This revision was automatically updated to reflect the committed changes.