Differential D25505

Associate output transforms and orientations
ClosedPublic
Actions

Authored by romangg on Nov 24 2019, 11:40 AM.

Details

Reviewers

None

Group Reviewers

KWin

Maniphest Tasks

T11670: Improve Wayland output rotation

Commits

R108:6bfa931f2b1d: Associate output transforms and orientations

Summary

We use internally Qt:ScreenOrientation for representing output transforms.

This is not ideal since the values do not map directly to Wayland transform
values, but we can make it work by using OR combinations of
Qt:ScreenOrientations.

Do this for now and see if we should not better introduce an internal enum
mapped directly.

Additionally the OR combinations need to be handled in the drm backend at
various places accordingly as well (see TODOs).

Test Plan

Compiles

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

romangg created this revision.Nov 24 2019, 11:40 AM

Restricted Application added a project: KWin. · View Herald TranscriptNov 24 2019, 11:40 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

romangg requested review of this revision.Nov 24 2019, 11:40 AM

Harbormaster completed remote builds in B19120: Diff 70256.Nov 24 2019, 11:40 AM

romangg added a dependency: D25504: Set transform in AbstractWaylandOutput.Nov 24 2019, 11:40 AM

romangg added a dependent revision: D25507: Set orientation from DRM on fallback.Nov 24 2019, 4:09 PM

romangg added a task: T11670: Improve Wayland output rotation.Nov 26 2019, 9:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 26 2019, 9:29 PM

Closed by commit R108:6bfa931f2b1d: Associate output transforms and orientations (authored by romangg). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			abstract_output.h (7 lines)
M			abstract_output.cpp (5 lines)
M			abstract_wayland_output.h (11 lines)
M			abstract_wayland_output.cpp (25 lines)
M			outputscreens.h (1 line)
M			outputscreens.cpp (8 lines)
M			plugins/platforms/drm/drm_output.h (2 lines)
M			plugins/platforms/drm/drm_output.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	70256	0ff6b0d		Nov 24 2019, 11:40 AM	★	★
Diff 2	70377	523967b	R108:6bfa931f2b1d9787e75c4be4e44611d51ba835c3	Nov 26 2019, 9:29 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
7d4b6d514da6	c34ff3b42f92	0ff6b0d92f9d	Roman Gilg	Associate output transforms and orientations (Show More…)	Nov 24 2019, 11:26 AM

Status	Author	Revision
Closed	romangg	D25558 Use Transform enum internally
Closed	romangg	D25507 Set orientation from DRM on fallback
Closed	romangg	D25505 Associate output transforms and orientations
Closed	romangg	D25504 Set transform in AbstractWaylandOutput