Differential D25501

FreeBSD: lld does not support -Wl,-z,nodump
ClosedPublic
Actions

Authored by tcberner on Nov 24 2019, 8:03 AM.

Details

Reviewers
mutlaqja
Group Reviewers
FreeBSD
KStars
Commits
R321:100777109dde: FreeBSD: lld does not support -Wl,-z,nodump
Summary

kstars appends -Wl,-z,nodump to the linker flags, which is not supported by lld>=7 (previous versions just discareded unkonwn flags).

Add cmake module to check for support of the flag. (See also the abandoned D17863).

This should fix the build on FreeBSD CI.

Test Plan
  • Should be tested on Linux too.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcberner created this revision.Nov 24 2019, 8:03 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptNov 24 2019, 8:03 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
tcberner requested review of this revision.Nov 24 2019, 8:03 AM
tcberner edited the summary of this revision. (Show Details)Nov 24 2019, 8:04 AM
mutlaqja accepted this revision.Nov 24 2019, 8:11 AM
This revision is now accepted and ready to land.Nov 24 2019, 8:11 AM
Closed by commit R321:100777109dde: FreeBSD: lld does not support -Wl,-z,nodump (authored by tcberner). · Explain WhyNov 24 2019, 8:31 AM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 70251