Deleting the about dialog when it gets closed
ClosedPublic

Authored by ivan on Aug 23 2016, 11:49 AM.

Details

Summary

We are providing the parent if it is a QWidget, but still,
there is no need to have this window remain in memory
after closing.

If the parent is not a QWidget, this is a memory leak.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ivan updated this revision to Diff 6189.Aug 23 2016, 11:49 AM
ivan retitled this revision from to Deleting the about dialog when it gets closed.
ivan updated this object.
ivan edited the test plan for this revision. (Show Details)
ivan added reviewers: Plasma, mart.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 23 2016, 11:49 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Aug 23 2016, 11:55 AM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Aug 23 2016, 11:55 AM
This revision was automatically updated to reflect the committed changes.