Save combobox value instead of index
Needs ReviewPublic

Authored by guoyunhe on Fri, Nov 22, 8:16 PM.

Details

Reviewers
None
Group Reviewers
Spectacle
Summary

When plugging or unplugging external monitors, the items of the combobox can change. So index 1 can be "Active Window" this time, and "Current Desktop" next time. This patch saves the value of combobox. So it always remember "active window" no matter how the list changes.

Diff Detail

Repository
R166 Spectacle
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19074
Build 19092: arc lint + arc unit
guoyunhe created this revision.Fri, Nov 22, 8:16 PM
Restricted Application added a project: Spectacle. · View Herald TranscriptFri, Nov 22, 8:16 PM
Restricted Application added a subscriber: Spectacle. · View Herald Transcript
guoyunhe requested review of this revision.Fri, Nov 22, 8:16 PM

I added a similar fix earlier today to
D23316

Yeah, look exactly the same, maybe yours is better (with configuration update script). We can close this one when yours get accepted.