Migrate wallpaper config UI to Qt Quick Controls 2 and Kirigami
ClosedPublic

Authored by guoyunhe on Nov 22 2019, 7:23 PM.

Details

Summary

KCM UI is gradually moving to Qt Quick Controls 2 components and Kirigami form layout. This can solve some layout consistency issue and HiDPI rendering issue (QQC1 doesn't render properly in HiDPI screen).

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
guoyunhe created this revision.Nov 22 2019, 7:23 PM
Restricted Application added projects: Marble, KDE Edu. · View Herald TranscriptNov 22 2019, 7:23 PM
Restricted Application added subscribers: kde-edu, marble-devel. · View Herald Transcript
guoyunhe requested review of this revision.Nov 22 2019, 7:23 PM
guoyunhe edited the summary of this revision. (Show Details)Nov 22 2019, 7:26 PM
guoyunhe added reviewers: Marble, Plasma.
ngraham added inline comments.
src/plasma/wallpapers/worldmap/contents/ui/config.qml
22–23

import QtQuick.Controls 2.5 as QQC2

23

2.5

31–32

This should be the top-level layout now; no need to keep it inside a ColumnLayout

62–63

This will no longer be needed and can be removed

guoyunhe updated this revision to Diff 70185.Nov 22 2019, 8:21 PM

Update QQC2 and Kirigami version and remove top level ColumnLayout

ngraham accepted this revision.Nov 23 2019, 12:16 AM
This revision is now accepted and ready to land.Nov 23 2019, 12:16 AM
This revision was automatically updated to reflect the committed changes.