Move logic for services autostart from klauncher to ksmserver
ClosedPublic

Authored by davidedmundson on Aug 23 2016, 7:49 AM.

Details

Summary

Currently ksmserver sends DBus calls to klauncher to autostart services.

This patch brings all autostarting into the ksmserver process, putting
all autostart code together, and improving Plasma/Frameworks separation
(change requested by David Faure) with the long term goal of removing
this from klauncher; with a longer term goal of maybe even killing
klauncher.

We don't get two things autostarting as without ksmserver sending the
signals, klauncher does nothing.

Autostart.cpp code is copied verbatim so there's no breakage.

Test Plan

Logged in, got plasma and krunner and so on.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson retitled this revision from to Move logic for services autostart from klauncher to ksmserver.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 23 2016, 7:49 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added a subscriber: mart.Aug 23 2016, 8:27 AM

wouldn't this need to be done all over again in wayland as there wouldn't be ksmserver anymore?

Seems startplasma (invoked by kwin_wayland) starts it.

startplasma:146
kwrapper5 @CMAKE_INSTALL_FULL_BINDIR@/ksmserver $KDEWM $KSMSERVEROPTIONS

and even if it does move to someplace else you'd have to move the current code that invokes OrgKdeKLauncherInterface somewhere. Moving this code wouldn't be too different.

graesslin accepted this revision.Aug 24 2016, 11:22 AM
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.Aug 24 2016, 11:22 AM
This revision was automatically updated to reflect the committed changes.