Add some test to ensure local time handling in recurrences.
ClosedPublic

Authored by dcaliste on Nov 20 2019, 11:51 AM.

Details

Summary

Add two tests ensuring that various exception time
formats are properly applied or ignored for recurring
event in local time. The rational is: an event in local time
should apply exception if the exception is in local time and
matching, or is given with a time zone and matching when
converted to the current time zone.

Test Plan

Two tests have been added.

Diff Detail

Repository
R172 KCalendar Core
Branch
localtime
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18979
Build 18997: arc lint + arc unit
dcaliste created this revision.Nov 20 2019, 11:51 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptNov 20 2019, 11:51 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dcaliste requested review of this revision.Nov 20 2019, 11:51 AM

There actually is no bug in KCalendarCore regarding this topic of exceptions for a local time event. We had to fix various ones in SailfishOS ancient version of KCalCore and we have added tests for this. I'm happy to see that the tests are passing in KCalendarCore out of the box, and since we crafted these tests, I'm proposing to add them here.

dvratil accepted this revision.Nov 20 2019, 12:41 PM
dvratil added a subscriber: dvratil.

Much appreciated!

This revision is now accepted and ready to land.Nov 20 2019, 12:41 PM
dcaliste closed this revision.Nov 20 2019, 5:11 PM