[Folder view] Use selected text color for selected items in full representation
ClosedPublic

Authored by ngraham on Tue, Nov 19, 9:52 PM.

Details

Summary

Right now, selected (not highlighted) items in the popup persist in using
the default text color , which can result in readability problems for light
themes that use a dark highlight effect.

BUG: 414287
FIXED-IN: 5.17.4

Test Plan

Put a Folder widget in a horizontal panel, click it, hover the mouse over one
of the items in the list, and then click.

Before:

After:

No change or regressions for selected items in Folder View on the desktop.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Tue, Nov 19, 9:52 PM
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Nov 19, 9:52 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Tue, Nov 19, 9:52 PM
ngraham edited the summary of this revision. (Show Details)Tue, Nov 19, 9:53 PM
ngraham edited the test plan for this revision. (Show Details)
ndavis added a subscriber: ndavis.Wed, Nov 20, 9:53 PM

It looks like your highlight effect is bugged or you are using a modified desktop theme. Here's what mine looks like:

That was my first reaction in the bug report as well (see the discussion there). But try clicking on that file, not just highlighting it. :)

ngraham edited the summary of this revision. (Show Details)Wed, Nov 20, 9:57 PM
ngraham edited the test plan for this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)
ndavis accepted this revision.Wed, Nov 20, 10:41 PM

That was my first reaction in the bug report as well (see the discussion there). But try clicking on that file, not just highlighting it. :)

I see. It seems like it's stuck halfway between looking like Kickoff and behaving like Dolphin.

If you make the text use the highlighted text color, we might have to undo that later on with the Breeze theme evolution. I'm not yet sure what the best way to differentiate selected list items and a hovered list items is.

I suppose it wouldn't hurt to do this change now just to fix the bug though.

containments/desktop/package/contents/ui/FolderItemDelegate.qml
354

Is there not a better way to make nested if statements in QML?

This revision is now accepted and ready to land.Wed, Nov 20, 10:41 PM
ngraham updated this revision to Diff 70125.Thu, Nov 21, 8:59 PM

Use a more comprehensible way to conditionally define the text color

ngraham marked an inline comment as done.Thu, Nov 21, 8:59 PM

Yeah for the future, we'll need to definitively sort out the visual appearance of the selected/highlighted vs hovered states.

This revision was automatically updated to reflect the committed changes.