Don't add and remove player element if it is already in the page
ClosedPublic
Actions

Authored by broulik on Nov 18 2019, 8:15 AM.

Details

Reviewers

fvogt
tasossahanidis

Group Reviewers

Plasma

Commits

R856:47a2790188bf: Don't add and remove player element if it is already in the page

Summary

In case the player has genuinely been added to the website as visible player control.

CCBUG: 411742

Test Plan

Wikipedia player works again: https://en.wikipedia.org/wiki/File:Thunder.ogg
All of the test cases in D24870 still work

Diff Detail

Repository

R856 Plasma Browser Integration

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik created this revision.Nov 18 2019, 8:15 AM

Restricted Application added a project: Plasma. · View Herald TranscriptNov 18 2019, 8:15 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Nov 18 2019, 8:15 AM

I can confirm that the Wikipedia player works correctly again, as well as the websites outlined in the test cases (that I have access to) continue to function as expected.

Thank you

This revision is now accepted and ready to land.Nov 18 2019, 8:25 AM

Closed by commit R856:47a2790188bf: Don't add and remove player element if it is already in the page (authored by broulik). · Explain WhyNov 18 2019, 8:38 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			extension/content-script.js (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	69904			Nov 18 2019, 8:12 AM	★	★
Diff 2	69905	7b033c5	R856:47a2790188bf0a6d05fdbc94b6378f26514313ac	Nov 18 2019, 8:38 AM	★	★

Diff 69905

View Options

extension/content-script.js