Differential D25329

Fix KIO errors text formatting
ClosedPublic
Actions

Authored by trufanov on Nov 15 2019, 3:12 PM.

Details

Reviewers
stikonas
Commits
R472:f8358c81d1b2: Fix KIO errors text formatting
Summary

It seems forwarding errorText() is required for all KIO errors bcs some error messages aren't build only basing on error code. For example I was getting "Timeout on server\n" instead of "Timeout on server\nbt-2.t-ru.org: Socked operation timed out" that resulted in unnecessary raw height of Tracker list in KTorrent. (https://github.com/KDE/kio/blob/f0456fa7528cd6a68d9cbd97ca5aef19f830b588/src/core/job_error.cpp#L188)

This is not a mistake in HTTP error page processing commit. This is the old bug.

Diff Detail

Repository
R472 KTorrent Library
Lint
Lint Skipped
Unit
Unit Tests Skipped
trufanov requested review of this revision.Nov 15 2019, 3:12 PM
trufanov created this revision.
stikonas accepted this revision.Nov 15 2019, 3:18 PM

Looks good

This revision is now accepted and ready to land.Nov 15 2019, 3:18 PM
Closed by commit R472:f8358c81d1b2: Fix KIO errors text formatting (authored by trufanov). · Explain WhyNov 15 2019, 3:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/tracker/kioannouncejob.cpp (4 lines)

Diff 69810

View Options

src/tracker/kioannouncejob.cpp

Loading...