gassaf (Gilbert Assaf)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 19 2017, 1:00 PM (126 w, 4 d)
Availability
Available

Recent Activity

Jan 7 2019

gassaf committed R353:c77175cd2d90: "Zero as null pointer constant" warnings fixed (authored by gassaf).
"Zero as null pointer constant" warnings fixed
Jan 7 2019, 8:47 PM
gassaf closed D17901: "Zero as null pointer constant" warnings fixed.
Jan 7 2019, 8:47 PM

Jan 1 2019

gassaf updated the summary of D17901: "Zero as null pointer constant" warnings fixed.
Jan 1 2019, 5:15 PM
gassaf requested review of D17901: "Zero as null pointer constant" warnings fixed.
Jan 1 2019, 5:12 PM

Aug 15 2018

gassaf committed R223:fcf148b75b98: Fixes url whitespaces in epub documents (authored by gassaf).
Fixes url whitespaces in epub documents
Aug 15 2018, 5:14 PM
gassaf closed D14310: Fixes url whitespaces in epub documents.
Aug 15 2018, 5:14 PM · Okular

Aug 11 2018

gassaf added a comment to D14310: Fixes url whitespaces in epub documents.

Here you go. I created this epub document via a free software tool called sigil.

Aug 11 2018, 6:12 PM · Okular
gassaf updated the diff for D14310: Fixes url whitespaces in epub documents.

epub generator unit test added

Aug 11 2018, 6:10 PM · Okular

Jul 23 2018

gassaf added a reviewer for D14310: Fixes url whitespaces in epub documents: Okular.
Jul 23 2018, 9:30 PM · Okular
gassaf requested review of D14310: Fixes url whitespaces in epub documents.
Jul 23 2018, 9:28 PM · Okular

Jul 5 2018

gassaf added a comment to D13766: fixed picture scaling issues in epub generator.

Same here: Regular DPI without scaling.

Jul 5 2018, 8:19 PM · Okular

Jun 30 2018

gassaf added a comment to D13766: fixed picture scaling issues in epub generator.

I did some more tests and epub_get_data() always returned the correct size.

Jun 30 2018, 11:11 AM · Okular

Jun 28 2018

gassaf added a comment to D13766: fixed picture scaling issues in epub generator.

I tried commenting out the two lines (+if clause, so line 88 - 91) and all pictures are looking fine. Except that they are sometimes to big and break layout. So I would argue Okular does load all pictures with the correct solution, but the down-scaling part made them look blurry.

Jun 28 2018, 3:56 PM · Okular

Jun 27 2018

gassaf updated the test plan for D13766: fixed picture scaling issues in epub generator.
Jun 27 2018, 6:31 PM · Okular
gassaf requested review of D13766: fixed picture scaling issues in epub generator.
Jun 27 2018, 6:25 PM · Okular

Jan 26 2018

gassaf removed a watcher for Spectacle: gassaf.
Jan 26 2018, 7:12 PM

Jan 22 2018

gassaf removed a watcher for Okular: gassaf.
Jan 22 2018, 11:30 AM

Nov 22 2017

gassaf added a watcher for Okular: gassaf.
Nov 22 2017, 5:57 PM
gassaf added a watcher for Spectacle: gassaf.
Nov 22 2017, 5:57 PM

Sep 12 2017

gassaf committed R223:99be29e50b3f: Merge branch 'master' of git://anongit.kde.org/okular (authored by gassaf).
Merge branch 'master' of git://anongit.kde.org/okular
Sep 12 2017, 9:07 PM
gassaf committed R223:6b27aa53fa7b: CHM Generator Lib Update (authored by gassaf).
CHM Generator Lib Update
Sep 12 2017, 9:07 PM

May 31 2017

gassaf committed R223:786ec885264f: Bug 236688 - Sort pages according to TOC in CHM Files (authored by gassaf).
Bug 236688 - Sort pages according to TOC in CHM Files
May 31 2017, 11:16 AM
gassaf committed R223:ff1647ce6885: CHM: zooming changes the font size (authored by gassaf).
CHM: zooming changes the font size
May 31 2017, 11:13 AM
gassaf committed R223:e876640c215f: Bug 262265 chmlib should not send qFatal if encoding could not be guessed (authored by gassaf).
Bug 262265 chmlib should not send qFatal if encoding could not be guessed
May 31 2017, 11:03 AM
gassaf committed R223:357f198c1e69: kio_msits emits mimetype again (authored by gassaf).
kio_msits emits mimetype again
May 31 2017, 11:01 AM