gassaf (Gilbert Assaf)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 19 2017, 1:00 PM (149 w, 20 h)
Availability
Available

Recent Activity

Jan 24 2020

gassaf committed R305:f9f0465b6352: Port away from KLineEdit and KComboBox to Q equivalent (authored by gassaf).
Port away from KLineEdit and KComboBox to Q equivalent
Jan 24 2020, 12:32 AM
gassaf closed D26677: Port away from KLineEdit and KComboBox to Q equivalent.
Jan 24 2020, 12:32 AM · Frameworks

Jan 16 2020

gassaf edited reviewers for D26677: Port away from KLineEdit and KComboBox to Q equivalent, added: Frameworks; removed: kde-frameworks-devel.
Jan 16 2020, 11:13 PM · Frameworks

Jan 14 2020

gassaf added a reviewer for D26677: Port away from KLineEdit and KComboBox to Q equivalent: kde-frameworks-devel.
Jan 14 2020, 11:30 PM · Frameworks
gassaf added a revision to T12168: KNotifyConfig: Port away from KLineEdit and KComboBox to Q equivalent: D26677: Port away from KLineEdit and KComboBox to Q equivalent.
Jan 14 2020, 11:30 PM · KF6
gassaf added a task to D26677: Port away from KLineEdit and KComboBox to Q equivalent: T12168: KNotifyConfig: Port away from KLineEdit and KComboBox to Q equivalent.
Jan 14 2020, 11:30 PM · Frameworks
gassaf requested review of D26677: Port away from KLineEdit and KComboBox to Q equivalent.
Jan 14 2020, 11:28 PM · Frameworks

Dec 31 2019

gassaf added a comment to T11539: Port Okular away from KHTML.

The only think Okular knows how to show is QImages.

Ahh ok, than I don't know, if porting is even possible, without putting tremendous effort into it. Or QWebEngine somehow gets the featurem to render QImages. But I doubt that, since it is using a completely different render framework.

Dec 31 2019, 2:23 PM · Okular, KF6
gassaf added a comment to T11539: Port Okular away from KHTML.

there is a kchmviewer that uses qtwebengine directly for rendering. I don't know how that fits in the okular way of doing things.

Okular already uses the kchmviewer backend code, which supports two modes, QWebEngine and using KTHML. But switching to QWebEngine would break the current workflow used in okular, which is basically to render a page with khtml as a QImage and than return this QImage. AFAIK this is not possible with QWebEngine. So Okular would probably need a new Generator base class, to display HTML Documents using QWebEngine?

Dec 31 2019, 12:09 AM · Okular, KF6

Dec 8 2019

gassaf committed R473:91de705359dd: Fixes crash, when removing last torrent.BUG: 388803 (authored by gassaf).
Fixes crash, when removing last torrent.BUG: 388803
Dec 8 2019, 12:37 AM
gassaf closed D25680: Fixes crash, when removing last torrent.BUG: 388803.
Dec 8 2019, 12:37 AM
gassaf updated the diff for D25680: Fixes crash, when removing last torrent.BUG: 388803.
  • Iterate over copy
Dec 8 2019, 12:16 AM

Dec 7 2019

gassaf added a comment to D25680: Fixes crash, when removing last torrent.BUG: 388803.

I use the for loop now and I have also removed that line with trailing white spaces.

Dec 7 2019, 12:30 AM
gassaf updated the diff for D25680: Fixes crash, when removing last torrent.BUG: 388803.

use for loop instead of foreach

Dec 7 2019, 12:28 AM

Dec 2 2019

gassaf added reviewers for D25680: Fixes crash, when removing last torrent.BUG: 388803: stikonas, trufanov.
Dec 2 2019, 11:17 AM
gassaf requested review of D25680: Fixes crash, when removing last torrent.BUG: 388803.
Dec 2 2019, 11:15 AM

Nov 29 2019

gassaf moved T11609: Port KTorrent away from WebKit from Backlog to Done on the KF6 board.
Nov 29 2019, 9:00 AM · KF6

Nov 28 2019

gassaf committed R473:f5a1958ebdca: Port KTorrent to QWebEngine (authored by gassaf).
Port KTorrent to QWebEngine
Nov 28 2019, 11:41 PM
gassaf closed D25314: Port KTorrent to QWebEngine.
Nov 28 2019, 11:41 PM

Nov 24 2019

gassaf updated the diff for D25314: Port KTorrent to QWebEngine.

Thanks for the feedback, should be all fixed now.

Nov 24 2019, 11:56 PM

Nov 21 2019

gassaf added a reviewer for D25314: Port KTorrent to QWebEngine: stikonas.

Who would be the correct person to review this? Apparently there is no current maintainer for ktorrent but stikonas seems to approve the latest changes to ktorrent?

Nov 21 2019, 11:09 PM

Nov 15 2019

gassaf claimed T11609: Port KTorrent away from WebKit.
Nov 15 2019, 2:05 AM · KF6
gassaf added a revision to T11609: Port KTorrent away from WebKit: D25314: Port KTorrent to QWebEngine.
Nov 15 2019, 2:05 AM · KF6
gassaf added a task to D25314: Port KTorrent to QWebEngine: T11609: Port KTorrent away from WebKit.
Nov 15 2019, 2:05 AM
gassaf requested review of D25314: Port KTorrent to QWebEngine.
Nov 15 2019, 1:55 AM

Nov 3 2019

gassaf added a comment to T10002: Integration into Explorer.

This already be done via Windows "Send to" menu

Nov 3 2019, 4:52 PM · Windows, KDE Connect

Jan 7 2019

gassaf committed R353:c77175cd2d90: "Zero as null pointer constant" warnings fixed (authored by gassaf).
"Zero as null pointer constant" warnings fixed
Jan 7 2019, 8:47 PM
gassaf closed D17901: "Zero as null pointer constant" warnings fixed.
Jan 7 2019, 8:47 PM

Jan 1 2019

gassaf updated the summary of D17901: "Zero as null pointer constant" warnings fixed.
Jan 1 2019, 5:15 PM
gassaf requested review of D17901: "Zero as null pointer constant" warnings fixed.
Jan 1 2019, 5:12 PM

Aug 15 2018

gassaf committed R223:fcf148b75b98: Fixes url whitespaces in epub documents (authored by gassaf).
Fixes url whitespaces in epub documents
Aug 15 2018, 5:14 PM
gassaf closed D14310: Fixes url whitespaces in epub documents.
Aug 15 2018, 5:14 PM · Okular

Aug 11 2018

gassaf added a comment to D14310: Fixes url whitespaces in epub documents.

Here you go. I created this epub document via a free software tool called sigil.

Aug 11 2018, 6:12 PM · Okular
gassaf updated the diff for D14310: Fixes url whitespaces in epub documents.

epub generator unit test added

Aug 11 2018, 6:10 PM · Okular

Jul 23 2018

gassaf added a reviewer for D14310: Fixes url whitespaces in epub documents: Okular.
Jul 23 2018, 9:30 PM · Okular
gassaf requested review of D14310: Fixes url whitespaces in epub documents.
Jul 23 2018, 9:28 PM · Okular

Jul 5 2018

gassaf added a comment to D13766: fixed picture scaling issues in epub generator.

Same here: Regular DPI without scaling.

Jul 5 2018, 8:19 PM · Okular

Jun 30 2018

gassaf added a comment to D13766: fixed picture scaling issues in epub generator.

I did some more tests and epub_get_data() always returned the correct size.

Jun 30 2018, 11:11 AM · Okular

Jun 28 2018

gassaf added a comment to D13766: fixed picture scaling issues in epub generator.

I tried commenting out the two lines (+if clause, so line 88 - 91) and all pictures are looking fine. Except that they are sometimes to big and break layout. So I would argue Okular does load all pictures with the correct solution, but the down-scaling part made them look blurry.

Jun 28 2018, 3:56 PM · Okular

Jun 27 2018

gassaf updated the test plan for D13766: fixed picture scaling issues in epub generator.
Jun 27 2018, 6:31 PM · Okular
gassaf requested review of D13766: fixed picture scaling issues in epub generator.
Jun 27 2018, 6:25 PM · Okular

Jan 26 2018

gassaf removed a watcher for Spectacle: gassaf.
Jan 26 2018, 7:12 PM

Jan 22 2018

gassaf removed a watcher for Okular: gassaf.
Jan 22 2018, 11:30 AM

Nov 22 2017

gassaf added a watcher for Okular: gassaf.
Nov 22 2017, 5:57 PM
gassaf added a watcher for Spectacle: gassaf.
Nov 22 2017, 5:57 PM

Sep 12 2017

gassaf committed R223:99be29e50b3f: Merge branch 'master' of git://anongit.kde.org/okular (authored by gassaf).
Merge branch 'master' of git://anongit.kde.org/okular
Sep 12 2017, 9:07 PM
gassaf committed R223:6b27aa53fa7b: CHM Generator Lib Update (authored by gassaf).
CHM Generator Lib Update
Sep 12 2017, 9:07 PM

May 31 2017

gassaf committed R223:786ec885264f: Bug 236688 - Sort pages according to TOC in CHM Files (authored by gassaf).
Bug 236688 - Sort pages according to TOC in CHM Files
May 31 2017, 11:16 AM
gassaf committed R223:ff1647ce6885: CHM: zooming changes the font size (authored by gassaf).
CHM: zooming changes the font size
May 31 2017, 11:13 AM
gassaf committed R223:e876640c215f: Bug 262265 chmlib should not send qFatal if encoding could not be guessed (authored by gassaf).
Bug 262265 chmlib should not send qFatal if encoding could not be guessed
May 31 2017, 11:03 AM
gassaf committed R223:357f198c1e69: kio_msits emits mimetype again (authored by gassaf).
kio_msits emits mimetype again
May 31 2017, 11:01 AM