[Tabs Runner] Filter on the host side already
Needs RevisionPublic

Authored by broulik on Nov 12 2019, 6:03 PM.

Details

Reviewers
fvogt
davidedmundson
Group Reviewers
Plasma
Summary

Avoids allowing to query for all tabs easily and also reduces DBus traffic somewhat.

Test Plan

Still finds all my tabs.
Ideally, the filtering is done on the extension side already but that requires more effort and especially a compatibility path, however I don't really consider older extension with newer host a valid usecase since extension is easily installable and updatable through the browser store, whereas host comes from distro and might be old. For now, I'll leave it at that.

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Nov 12 2019, 6:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 12 2019, 6:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Nov 12 2019, 6:03 PM
broulik edited the test plan for this revision. (Show Details)Nov 12 2019, 6:06 PM
davidedmundson requested changes to this revision.Nov 12 2019, 9:24 PM
davidedmundson added a subscriber: davidedmundson.

If we're going to do this, we may as well merge the existing DBus runner (which I had a patch on phabricator since forever) instead of completely duplicating it with a custom API.

This revision now requires changes to proceed.Nov 12 2019, 9:24 PM