Differential D25264

[Cursor Theme KCM] Elide size ComboBox text
ClosedPublic
Actions

Authored by broulik on Nov 11 2019, 7:14 PM.

Details

Reviewers
IlyaBizyaev
ngraham
Group Reviewers
Plasma
Commits
R119:582bd8e04af0: [Cursor Theme KCM] Elide size ComboBox text
Summary

Vanilla ItemDelegate elides but this one has custom contentItem to add the cursor preview.
This lead to the delegate text overflowing its bounds on certain locales.

Test Plan

5.17
Doesn't overflow anymore with long text

Ideally we supported icon property of AbstractButton in qqc2-desktop-style ItemDelegate, forced a width and height for the icon and then don't use a custom delegate whatsoever :)

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Nov 11 2019, 7:14 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 11 2019, 7:14 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Nov 11 2019, 7:14 PM
broulik edited the test plan for this revision. (Show Details)
ngraham accepted this revision.Nov 11 2019, 8:21 PM
This revision is now accepted and ready to land.Nov 11 2019, 8:21 PM
Closed by commit R119:582bd8e04af0: [Cursor Theme KCM] Elide size ComboBox text (authored by broulik). · Explain WhyNov 12 2019, 8:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 69624

View Options

kcms/cursortheme/package/contents/ui/main.qml

Loading...