Add an overlay component for item activity feedback
ClosedPublic

Authored by leinir on Nov 7 2019, 12:07 PM.

Details

Summary

This is the very first steps toward allowing for better, more involved
feedback on what is happening with the items (such as download progress,
the ability to abort installations, and such things).

BUG:413441

Also removes a now unneeded passive notification call

Test Plan

Without this patch, as mentioned in https://bugs.kde.org/show_bug.cgi?id=413441

With this patch:

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Nov 7 2019, 12:07 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 7 2019, 12:07 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
leinir requested review of this revision.Nov 7 2019, 12:07 PM
leinir edited the test plan for this revision. (Show Details)Nov 7 2019, 12:08 PM
ngraham accepted this revision.Nov 7 2019, 2:02 PM

Good stuff.

src/qtquick/qml/private/entrygriddelegates/FeedbackOverlay.qml
64

Bonus points for showing a link that actually takes you to https://bugs.kde.org/enter_bug.cgi?product=frameworks-knewstuff when this error condition is present

This revision is now accepted and ready to land.Nov 7 2019, 2:02 PM
This revision was automatically updated to reflect the committed changes.
leinir added inline comments.Nov 7 2019, 2:09 PM
src/qtquick/qml/private/entrygriddelegates/FeedbackOverlay.qml
64

Couple of places where that wants to happen, yup :)