Differential D2513

Adding tooltip to symbolsviewer plugin
ClosedPublic
Actions

Authored by ofelt on Aug 20 2016, 11:21 PM.

Details

Reviewers
cullmann
kwrite-devel
Group Reviewers
Kate
Commits
R40:0e1086254f26: Add tooltip to symbolsviewer plugin
Summary

Tooltip was not used previously.
This patch display function parameters in tooltip.

Test Plan

Expect same behavior as before and see correct tooltips.
Opened with 3 test files (php, cpp, rb) in kate.
Behavior same as before and tooltips are correct.

Diff Detail

Repository
R40 Kate
Lint
Lint Skipped
Unit
Unit Tests Skipped
ofelt updated this revision to Diff 6108.Aug 20 2016, 11:21 PM
ofelt retitled this revision from to Adding tooltip to symbolsviewer plugin.
ofelt updated this object.
ofelt edited the test plan for this revision. (Show Details)
ofelt added a reviewer: kwrite-devel.
ofelt set the repository for this revision to R40 Kate.
ofelt added a project: Kate.
ofelt added a subscriber: kwrite-devel.
ofelt added a comment.Aug 20 2016, 11:25 PM

Hi there, It's my first patch for KDE, it's a small thing but useful :) Any advice is welcome ^^ Thanks. Oli

ofelt added a reviewer: Kate.Aug 21 2016, 8:14 AM
ofelt added a subscriber: Kate.
cullmann accepted this revision.Sep 3 2016, 3:14 PM
cullmann added a reviewer: cullmann.
cullmann added a subscriber: cullmann.

I would accept that way, can you commit it yourself?

This revision is now accepted and ready to land.Sep 3 2016, 3:14 PM
ofelt added a comment.Sep 3 2016, 8:21 PM

I don't have commit access yet, if you can commit it for me (Olivier Felt, olivier.felt@kdemail.net) it would be great
Thanks for your time

Closed by commit R40:0e1086254f26: Add tooltip to symbolsviewer plugin (authored by ofelt, committed by brauch). · Explain WhySep 3 2016, 8:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6108

View Options

addons/symbolviewer/cpp_parser.cpp

Loading...
View Options

addons/symbolviewer/php_parser.cpp

Loading...
View Options

addons/symbolviewer/ruby_parser.cpp

Loading...