Differential D2505

Don't do instant save
ClosedPublic
Actions

Authored by mart on Aug 19 2016, 2:30 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R118:9cf7ee9f4811: Don't do instant save
R855:9cf7ee9f4811: Don't do instant save
Summary

use a save button instead of having instant save on all the fields
this is more coherent with the behavior of normal applications

Diff Detail

Repository
R118 Plasma SDK
Branch
phab/savebutton
Lint
No Linters Available
Unit
No Unit Test Coverage
mart updated this revision to Diff 6082.Aug 19 2016, 2:30 PM
mart retitled this revision from to Don't do instant save.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
Restricted Application added a project: Plasma. · View Herald TranscriptAug 19 2016, 2:30 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson added a subscriber: davidedmundson.Aug 22 2016, 7:57 PM

There's an effective m_needsSave in KConfigModule; changed()

mart added a comment.Aug 22 2016, 8:00 PM
In D2505#47460, @davidedmundson wrote:

There's an effective m_needsSave in KConfigModule; changed()

this is a standalone app, not a KConfigModule

davidedmundson accepted this revision.Aug 22 2016, 8:15 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Aug 22 2016, 8:15 PM
Closed by commit R118:9cf7ee9f4811: Don't do instant save (authored by mart). · Explain WhyAug 22 2016, 8:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6082

View Options

lookandfeelexplorer/package/contents/ui/FormField.qml

Loading...
View Options

lookandfeelexplorer/package/contents/ui/main.qml

Loading...
View Options

lookandfeelexplorer/src/lnflogic.h

Loading...
View Options

lookandfeelexplorer/src/lnflogic.cpp

Loading...