Differential D25023

Make kconfig_compiler generate code with const &
AbandonedPublic
Actions

Authored by aacid on Oct 28 2019, 10:00 PM.

Details

Reviewers: None

Summary

KSharedConfig::Ptr is not very expensive to copy but const & is cheaper

Diff Detail

Repository

R237 KConfig

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18282
Build 18300: arc lint + arc unit

aacid created this revision.Oct 28 2019, 10:00 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptOct 28 2019, 10:00 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

aacid requested review of this revision.Oct 28 2019, 10:00 PM

Harbormaster completed remote builds in B18282: Diff 68926.Oct 28 2019, 10:00 PM

I don't know if we can do that. There's been some changes we've pulled back assuming people could be installing + exporting classes generated from kconfig_compiler. :/

aacid abandoned this revision.Oct 29 2019, 9:39 PM

Revision Contents
Changeset List

			Path	Packages
M			autotests/kconfig_compiler/test8a.h.ref (2 lines)
M			autotests/kconfig_compiler/test8a.cpp.ref (2 lines)
M			autotests/kconfig_compiler/test8c.h.ref (4 lines)
M			autotests/kconfig_compiler/test8c.cpp.ref (4 lines)
M			src/kconfig_compiler/kconfig_compiler.cpp (10 lines)