Differential D24971

KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui
ClosedPublic
Actions

Authored by dfaure on Oct 26 2019, 4:51 PM.

Details

Reviewers
kossebau
Commits
R244:ff99d352113a: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui
Summary

NO_CHANGELOG

Test Plan

Builds, and allows to build kconfigwidgets

Diff Detail

Repository
R244 KCoreAddons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18202
Build 18220: arc lint + arc unit
dfaure created this revision.Oct 26 2019, 4:51 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 26 2019, 4:51 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Oct 26 2019, 4:51 PM
kossebau added inline comments.Oct 26 2019, 5:02 PM
CMakeLists.txt
96 ↗(On Diff #68796)

Given KCOreAddons does not link against other KF modules, this does not make sense here.

src/lib/kaboutdata.h
944–945

Possibly best to document why only BUILD, pointing out infrastructure code supporting legacy code needs to always see this, unless disabled from build explicitly.
To avoid the next person thinking this was a mistake and changing to ENABLE again.

dfaure updated this revision to Diff 68798.Oct 26 2019, 5:20 PM

Revert change to CMakeLists.txt; explain change as comment

kossebau accepted this revision.Oct 26 2019, 5:24 PM

Good with me.

This revision is now accepted and ready to land.Oct 26 2019, 5:24 PM
dfaure closed this revision.Oct 26 2019, 5:42 PM

Revision Contents
Changeset List

PathPackages
Msrc/lib/kaboutdata.h (3 lines)

Diff 68798

View Options

src/lib/kaboutdata.h

Loading...