Sometimes applications or Plasma have different code paths for X11 or Wayland.
Drkonqi reporting that saves one "question -> wait for reply -> period until reply
is seen"-cycle.
Details
Details
- Reviewers
sitter - Commits
- R871:8b8f813620b5: Report windowing system
Try it in test mode
Diff Detail
Diff Detail
- Repository
- R871 DrKonqi
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
CMakeLists.txt | ||
---|---|---|
30 ↗ | (On Diff #68608) | Do we know why this was done? |
CMakeLists.txt | ||
---|---|---|
30 ↗ | (On Diff #68608) | I don't know but I just moved the find_package WindowSystem out of the if because now it would be needed unconditionally. |
CMakeLists.txt | ||
---|---|---|
30 ↗ | (On Diff #68608) | on osx the dialog is doing forceActiveWindow, not sure why only on osx though |
src/systeminformation.cpp | ||
305 | You should probably just return QStringLiteral("Unknown") instead. The unreachable is fairly dangerous here. If the enum gets extended but not immediately updated in drkonqi this will lead to undefined behavior. |