Report windowing system
ClosedPublic

Authored by davidre on Wed, Oct 23, 1:35 PM.

Details

Summary

Sometimes applications or Plasma have different code paths for X11 or Wayland.
Drkonqi reporting that saves one "question -> wait for reply -> period until reply
is seen"-cycle.

Test Plan

Try it in test mode

Diff Detail

Repository
R871 DrKonqi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidre created this revision.Wed, Oct 23, 1:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Oct 23, 1:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidre requested review of this revision.Wed, Oct 23, 1:35 PM
davidre edited the summary of this revision. (Show Details)
apol added a subscriber: apol.Wed, Oct 23, 1:46 PM
apol added inline comments.
CMakeLists.txt
30

Do we know why this was done?

davidre added inline comments.Wed, Oct 23, 1:47 PM
CMakeLists.txt
30

I don't know but I just moved the find_package WindowSystem out of the if because now it would be needed unconditionally.

sitter requested changes to this revision.Wed, Oct 23, 2:17 PM
sitter added inline comments.
CMakeLists.txt
30

on osx the dialog is doing forceActiveWindow, not sure why only on osx though

src/systeminformation.cpp
305

You should probably just return QStringLiteral("Unknown") instead. The unreachable is fairly dangerous here. If the enum gets extended but not immediately updated in drkonqi this will lead to undefined behavior.

This revision now requires changes to proceed.Wed, Oct 23, 2:17 PM
davidre updated this revision to Diff 68607.Wed, Oct 23, 2:26 PM

report Unknown

davidre marked an inline comment as done.Wed, Oct 23, 2:27 PM
sitter accepted this revision.Wed, Oct 23, 2:44 PM

Oh it's gorgeous!

This revision is now accepted and ready to land.Wed, Oct 23, 2:44 PM
This revision was automatically updated to reflect the committed changes.