testing high level functionality of a bunch of relevant slaves yielded no
obvious problems, so let's enable slave state assertion for all builds from
git repos now. this should give much wider testing coverage
the build type warning has been removed because it would not serve any
purpose with KIO_ASSERT_SLAVE_STATES being automatically enabled regardless
of build type (Q_ASSERT eventually changes behavior based on type-dependent
flags anyway)
cmake with .git enables the option, without it doesn't, with .git and type set to Release a warning is printed
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| CMakeLists.txt | ||
|---|---|---|
| 47–48 | It does, but people can still pass -DCMAKE_BUILD_TYPE=Release, or RelWithDebInfo (as I do for profiling). Won't this give them the warning below then, even if they don't set the KIO_ASSERT_SLAVE_STATES option)? I would just set ASSERT_SLAVE_STATES_DEFAULT to OFF when the build type isn't Debug. | |
| CMakeLists.txt | ||
|---|---|---|
| 47–48 | Well, at that point you can choose to:
If you don't want that I'd actually get rid of the warning altogether. Determining what a given build type does isn't so reliably doable as users may have custom build types that define whatever, so the warning is more of a crutch than anything. | |
| CMakeLists.txt | ||
|---|---|---|
| 47–48 | Please kill the warning then. | |