Add hideOnWindowDeactivate to PlasmaComponents.Dialog
ClosedPublic

Authored by kmaterka on Oct 21 2019, 11:07 AM.

Details

Summary

When using Dialog or QueryDialog, it should be possible to set hideOnWindowDeactivate flag.

CCBUG: 401016

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kmaterka created this revision.Oct 21 2019, 11:07 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 21 2019, 11:07 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kmaterka requested review of this revision.Oct 21 2019, 11:07 AM
kmaterka edited the summary of this revision. (Show Details)Oct 21 2019, 11:09 AM
kmaterka added reviewers: Plasma, Frameworks.

This is a first step to solve 401016:
"Touchpad plasmoid [confirmation dialog] remains open when losing focus, I think that it is inconsistent since other elements of tray close themselves after switching away."

AFAIK PlasmaComponents 2 are deprecated. Is there newer QueryDialog replacement?

Should I proceed? This component has serious issues anyway, maybe there is no point in fixing this?
For example:
There is Loader that load always the same QML because... "if (true || ....)" - line 241. Even if this is obsolete, cleanup would be good idea.

davidedmundson accepted this revision.Nov 5 2019, 12:53 PM
This revision is now accepted and ready to land.Nov 5 2019, 12:53 PM
davidedmundson added a comment.EditedNov 5 2019, 12:55 PM

maybe there is no point in fixing this?

PlasmaComponents are somewhat deprectaed in favour of Plasma Components 3 (which have to match QtQuickControls2 API)

So maybe not, from what I can see the original code could use PlasmaCore.Dialog directly. Or the inbuilt way plasma does popups.

On the other hand, there's no harm to this patch either.

This revision was automatically updated to reflect the committed changes.