Differential D24769

Add tooltips to buttons in the annotation dialog
ClosedPublic
Actions

Authored by blackie on Oct 19 2019, 6:31 AM.

Details

Reviewers
johanneszarl
Group Reviewers
KPhotoAlbum
Commits
R463:1ef574975806: Add tooltips to buttons in the annotation dialog
R463:608fb8908129: Add tooltips to buttons in the annotation dialog

Diff Detail

Repository
R463 KPhotoAlbum
Branch
tooltips (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17883
Build 17901: arc lint + arc unit
blackie requested review of this revision.Oct 19 2019, 6:31 AM
blackie created this revision.
blackie added reviewers: KPhotoAlbum, johanneszarl.Oct 19 2019, 6:36 AM

Please review this patch.

johanneszarl added a comment.Oct 19 2019, 10:22 PM

Dynamically adding shortcut information to the tooltips is definitely an improvement ;-9
Could you write a more descriptive commit message, though?

johanneszarl added a comment.Oct 19 2019, 10:45 PM

On a side-note: I'll check whether there's a better way to translate the automatically added shortcut description (not that this changes anything for this specific patch).

This revision was not accepted when it landed; it landed in state Needs Review.Nov 12 2019, 11:54 AM
Closed by commit R463:1ef574975806: Add tooltips to buttons in the annotation dialog (authored by Jesper K. Pedersen <blackie@kde.org>). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 68276

View Options

AnnotationDialog/Dialog.cpp

Loading...
View Options

AnnotationDialog/ImagePreviewWidget.h

Loading...
View Options

AnnotationDialog/ImagePreviewWidget.cpp

Loading...