Differential D24764

Deprecate KIconTheme::assignIconsToContextMenu
ClosedPublic
Actions

Authored by vkrause on Oct 18 2019, 4:07 PM.

Details

Reviewers
mlaurent
Maniphest Tasks
T11865: Deprecate KIconTheme::assignIconsToContextMenu
Commits
R302:ccf27d634cbf: Deprecate KIconTheme::assignIconsToContextMenu
Summary

It's no longer necessary as Qt sets icons on context menu actions itself
by now.

Diff Detail

Repository
R302 KIconThemes
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Oct 18 2019, 4:07 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 18 2019, 4:07 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Oct 18 2019, 4:07 PM
mlaurent accepted this revision.Oct 18 2019, 4:20 PM
This revision is now accepted and ready to land.Oct 18 2019, 4:20 PM
Closed by commit R302:ccf27d634cbf: Deprecate KIconTheme::assignIconsToContextMenu (authored by vkrause). · Explain WhyOct 22 2019, 4:21 PM
This revision was automatically updated to reflect the committed changes.
kossebau added a subscriber: kossebau.Oct 22 2019, 5:31 PM

As KIconThems supports EXCLUDE_DEPRECATED_BEFORE_AND_AT., you want to also wrap the implementation of assignIconsToContextMenu, with #if KICONTHEMES_BUILD_DEPRECATED_SINCE(5, 64) (look out for _BUILD_).

Seems you are a candidate to answer the email https://mail.kde.org/pipermail/kde-frameworks-devel/2019-October/095831.html, please :)

src/kicontheme.h
291

IMHO moving the KICONTHEMES_DEPRECATED_VERSION onto an own line improves readability, especially with longer "what to do now" text arguments.

vkrause added a comment.Oct 23 2019, 4:32 PM

Follow up in D24892 to address the latest comments.

Revision Contents
Changeset List

PathPackages
Msrc/CMakeLists.txt (2 lines)
Msrc/kicontheme.h (10 lines)

Diff 68555

View Options

src/CMakeLists.txt

Loading...
View Options

src/kicontheme.h

Loading...