KOrganizer Month View: use QDate stringification
ClosedPublic

Authored by winterz on Oct 17 2019, 2:55 PM.

Details

Summary

Use the QDate toString to format the monthview header
this way we get localization for free.

Test Plan

header still looks like "October 2019" (in my locale)

Diff Detail

Repository
R76 PIM: Event Views
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
winterz created this revision.Oct 17 2019, 2:55 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 17 2019, 2:55 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
winterz requested review of this revision.Oct 17 2019, 2:55 PM
winterz updated this revision to Diff 68164.Oct 17 2019, 4:01 PM

I wonder if the original way was done for translation purposes? In any event, I think relying on localization makes more sense.

is it in all language we have Month + year ?
Because now we can"t customize it for each language.

is it in all language we have Month + year ?

I have no idea

Because now we can"t customize it for each language.

true

oh well. kinda seemed strange not to use the datestring function as intended. on the other hand, "if it's not broken=>don't fix it"

I grepped the localizations and it appears that everyone uses the "month year" format, so this change looks safe.

mlaurent accepted this revision.Oct 20 2019, 11:12 AM

Ok so As Dan wrote it seems ok.
So +2

This revision is now accepted and ready to land.Oct 20 2019, 11:12 AM
This revision was automatically updated to reflect the committed changes.