Depends on D24689.
Details
Details
Diff Detail
Diff Detail
- Repository
- R116 Plasma Network Management Applet
- Branch
- wpa3
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 17816 Build 17834: arc lint + arc unit
libs/editor/settings/wifisecurity.cpp | ||
---|---|---|
403 ↗ | (On Diff #68036) | It would be nice to convert use SecurityTypeIndex enum instead of hardcoded values. And then change WifiSecurity::securityChanged(int) to WifiSecurity::securityChanged(SecurityTypeIndex) if possible. |
415 ↗ | (On Diff #68036) | With an enum this could be merged easily with the WPA/WPA2 Enterprise index == 5 case. |
Comment Actions
Nice, I am properly not the best reviewer here, but it looks ok to me.
libs/editor/settings/wifisecurity.cpp | ||
---|---|---|
118 | It is very similar with securityIndex == WpaPsk) { // WPA if NetworkManager::wpaPskIsValid(m_ui->psk->text()) could be used instead of !m_ui->psk->text().isEmpty() we could use a single if block for both. |