Add support for WPA3
ClosedPublic

Authored by jgrulich on Oct 16 2019, 11:27 AM.

Details

Reviewers
meven
Group Reviewers
Plasma
Commits
R116:82e187663135: Add support for WPA3
Summary

Depends on D24689.

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jgrulich created this revision.Oct 16 2019, 11:27 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 16 2019, 11:27 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jgrulich requested review of this revision.Oct 16 2019, 11:27 AM
jgrulich edited the summary of this revision. (Show Details)Oct 16 2019, 11:28 AM
jgrulich added a reviewer: Plasma.
jgrulich updated this revision to Diff 68036.Oct 16 2019, 11:28 AM

Drop cmake change

meven added a subscriber: meven.Oct 17 2019, 9:55 AM
meven added inline comments.
libs/editor/settings/wifisecurity.cpp
403

It would be nice to convert use SecurityTypeIndex enum instead of hardcoded values.
It seems to me those values match.

And then change WifiSecurity::securityChanged(int) to WifiSecurity::securityChanged(SecurityTypeIndex) if possible.

415

With an enum this could be merged easily with the WPA/WPA2 Enterprise index == 5 case.

jgrulich updated this revision to Diff 68155.Oct 17 2019, 3:02 PM

Simplify code

jgrulich marked 2 inline comments as done.Oct 17 2019, 3:03 PM
meven accepted this revision.Mon, Nov 25, 1:45 PM

Nice, I am properly not the best reviewer here, but it looks ok to me.

libs/editor/settings/wifisecurity.cpp
118

It is very similar with securityIndex == WpaPsk) { // WPA if NetworkManager::wpaPskIsValid(m_ui->psk->text()) could be used instead of !m_ui->psk->text().isEmpty() we could use a single if block for both.
As a side note this if block could become a switch(securityIndex)

This revision is now accepted and ready to land.Mon, Nov 25, 1:45 PM
This revision was automatically updated to reflect the committed changes.