Differential D24647

[tabbox] Correctly set global short on kwin tabbox
ClosedPublic
Actions

Authored by davidedmundson on Oct 14 2019, 11:12 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:5d4be83de0c4: [tabbox] Correctly set global short on kwin tabbox
Summary

We need to set both the current autoload shortcut and the default
shortcut. setGlobalShortcut is a convenience method for both.

Otherwise clicking defaults in the keys KCM will discard the shortcut
forever.

BUG: 407000

Test Plan

wiped kglobalshortcutsrc to get a clean slate
restarted kwin
alt+tab
hit defauts in the kwin KCM
could still alt+tab

Diff Detail

Repository
R108 KWin
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 17694
Build 17712: arc lint + arc unit
Restricted Application added a project: KWin. · View Herald TranscriptOct 14 2019, 11:12 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Oct 14 2019, 11:12 PM
zzag accepted this revision.Oct 15 2019, 7:37 AM
This revision is now accepted and ready to land.Oct 15 2019, 7:37 AM
zzag added a comment.Oct 15 2019, 7:38 AM

It can go in 5.17 and maybe 5.12.

Closed by commit R108:5d4be83de0c4: [tabbox] Correctly set global short on kwin tabbox (authored by davidedmundson). · Explain WhyOct 15 2019, 11:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtabbox/tabbox.cpp (2 lines)

Diff 67932

View Options

tabbox/tabbox.cpp

Loading...