Use ECMGenerateExportHeader to manage deprecated API better
ClosedPublic
Actions

Authored by kossebau on Oct 13 2019, 1:52 PM.

Details

Reviewers

cfeck
mlaurent

Group Reviewers

Frameworks

Commits

Summary

Allows

projects linking to KIconThemes to hide deprecated API up to a given version or silence deprecation warnings after a given version, using
- -DKICONTHEMES_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKICONTHEMES_NO_DEPRECATED
- -DKICONTHEMES_DEPRECATED_WARNINGS_SINCE
- -DKICONTHEMES_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
to build KIconThemes optionally with deprecated API excluded from the build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

Test Plan

Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 4.8.0, 5.0.0,
5.63.0, CURRENT.

Repository

R302 KIconThemes

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

kossebau requested review of this revision.Oct 13 2019, 1:52 PM

Seems ok for me

This revision is now accepted and ready to land.Oct 13 2019, 5:23 PM

This revision was automatically updated to reflect the committed changes.

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	67843	37690b8		Oct 13 2019, 1:52 PM	★	★
Diff 2	68167	37690b8	R302:f046410b316fc98e7d7ee1219af97702f05c316a	Oct 17 2019, 4:04 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
f4d8aeba72d1	b97ac085516e	37690b8f064f	Friedrich W. H. Kossebau	Use ECMGenerateExportHeader to manage deprecated API better (Show More…)	Oct 13 2019, 1:49 PM