Differential D24606

Prevent user changing the stamp opacity
AbandonedPublic
Actions

Authored by simgunz on Oct 13 2019, 9:28 AM.

Details

Reviewers
aacid
Group Reviewers
Okular
VDG
Summary

When the stamp opacity is not 100% the resulting stamp is rendered with wierd colors

Diff Detail

Repository
R223 Okular
Branch
disable-setting-opacity-stamp
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17637
Build 17655: arc lint + arc unit
simgunz created this revision.Oct 13 2019, 9:28 AM
Restricted Application added a project: Okular. · View Herald TranscriptOct 13 2019, 9:28 AM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
simgunz requested review of this revision.Oct 13 2019, 9:28 AM
simgunz edited the summary of this revision. (Show Details)Oct 13 2019, 9:31 AM
simgunz added reviewers: Okular, VDG.


Left: stamps with opacity 50% and 30%, Right: stamps at 100% opacity


Resulting widget without opacity field

ngraham added a subscriber: ngraham.Oct 13 2019, 2:25 PM

Do we know why it's rendered incorrectly when not opaque? Is this a bug in Okular or Poppler?

aacid requested changes to this revision.Feb 21 2020, 6:54 PM
aacid added a subscriber: aacid.

Please move as a Merge Request in https://invent.kde.org/kde/okular

We have pre-commit CI and lots of checks including clazy and clang-tidy there so it's a much better place for doing the review/approval/merge of the code.

This revision now requires changes to proceed.Feb 21 2020, 6:54 PM

Revision Contents
Changeset List

PathPackages
Mui/annotationwidgets.cpp (1 line)

Diff 67829

View Options

ui/annotationwidgets.cpp

Loading...