Differential D24591

Set preview to correct device size
ClosedPublic
Actions

Authored by davidedmundson on Oct 12 2019, 1:44 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R123:9e0f84672748: Set preview to correct device size
Summary

QQuickImage::sourceSize is in device pixels for pixmap images.

Converting is the responsibility of the calling code.

BUG: 407689

Test Plan

QT_SCALE_FACTOR=1.5 kcmshell5 sddm
Looked at image

Diff Detail

Repository
R123 SDDM Configuration Panel (KCM)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Oct 12 2019, 1:44 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 12 2019, 1:44 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Oct 12 2019, 1:44 PM
apol accepted this revision.Oct 12 2019, 2:56 PM
This revision is now accepted and ready to land.Oct 12 2019, 2:56 PM
ngraham added a subscriber: ngraham.Oct 13 2019, 2:11 AM

This fixes the issue for the preview image of the currently-viewed theme, but not for the thumbnail images:

Closed by commit R123:9e0f84672748: Set preview to correct device size (authored by davidedmundson). · Explain WhyOct 13 2019, 4:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/qml/main.qml (5 lines)

Diff 67850

View Options

src/qml/main.qml

Loading...