Differential D24572

Remove libpala_export
Needs RevisionPublic
Actions

Authored by twighk on Oct 11 2019, 8:34 PM.

Details

Reviewers
aacid
Group Reviewers
KDE Games
Summary

LIBPALA_EXPORT Macro causes many linking errors when compiling with craft on windows using mingw.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
twighk created this revision.Oct 11 2019, 8:34 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptOct 11 2019, 8:34 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
twighk requested review of this revision.Oct 11 2019, 8:34 PM
aacid requested changes to this revision.Oct 12 2019, 10:55 PM
aacid added a subscriber: aacid.

This is wrong, these classes are part of a public library, they need the symbols to be exported

This revision now requires changes to proceed.Oct 12 2019, 10:55 PM

Revision Contents
Changeset List

Diff 67748

View Options

palapeli-19.08.1/libpala/slicer.h

Loading...
View Options

palapeli-19.08.1/libpala/slicerjob.h

Loading...
View Options

palapeli-19.08.1/libpala/slicermode.h

Loading...
View Options

palapeli-19.08.1/libpala/slicerproperty.h

Loading...