remove legacy space handling code
ClosedPublic

Authored by sitter on Oct 11 2019, 12:59 PM.

Details

Summary

the raw data in kioslaverc uses the format "$url $port", this format
isn't being read inside the KCM anymore though. instead setProxyInformation
is called with the output of KProtocolManager::proxyFor, which internally
merges the config entry to "$url:$port" already, so the space handling in
setProxyInformation was entirely superfluous and needlessly raising
complexity

Test Plan

saving and changing proxy settings continues to work

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Oct 11 2019, 12:59 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 11 2019, 12:59 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Oct 11 2019, 12:59 PM
dfaure accepted this revision.Oct 14 2019, 7:47 AM

If you say so :-)

This revision is now accepted and ready to land.Oct 14 2019, 7:47 AM
This revision was automatically updated to reflect the committed changes.