fix proxy setting loading
ClosedPublic

Authored by sitter on Oct 11 2019, 12:57 PM.

Details

Summary

when the flag isn't set we'd set the text to urlStr, urlStr however
was the original string *with* the port. since we want the port stripped
we need to actually set url.url() otherwise the KCM loading its own
settings would result in

Proxy: [socks://localhost:1080] Port: [1080]

which when written back to the file would result in broken data as we
do not sanitize the proxy url text WRT port when saving

Test Plan
  • set proxy
  • close and open kcm again
  • proxy values are what they were set to with no extra port duplication

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Oct 11 2019, 12:57 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 11 2019, 12:57 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Oct 11 2019, 12:57 PM
dfaure accepted this revision.Oct 12 2019, 9:40 PM

Err, yeah, the call to setPort(-1) serves no purpose at all otherwise...

This revision is now accepted and ready to land.Oct 12 2019, 9:40 PM
This revision was automatically updated to reflect the committed changes.