Differential D24556

[platforms/drm] Fix hardware cursor initialization
Needs ReviewPublic
Actions

Authored by ezequielg on Oct 11 2019, 11:32 AM.

Details

Reviewers

None

Group Reviewers

KWin

Summary

We can't connect cursor until drmOutput::initCursor
is called, which is done by drmBackend::updateOutputs.

Fix this by splitting the connect part into its own
drmBackend::connectCursor private function.

This allows to use the DRM legacy cursor API.

Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>

[platforms/drm] Allow to specify to dumb buffers' format

Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>

[platforms/drm] RFC/PoC: Support hardware cursors using DRM atomic API

This needs the new DRM AMEND uAPI in order to make sure
the cursor is committed on the same vblank as content.

Currently, the legacy cursor API is the best choice. Once the
AMEND uAPI is merged upstream, it'll be possible to switch to it.

Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>

Diff Detail

Repository

R108 KWin

Branch

atomic-cursors (branched from master)

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 17561
Build 17579: arc lint + arc unit

ezequielg created this revision.Oct 11 2019, 11:32 AM

Restricted Application added a project: KWin. · View Herald TranscriptOct 11 2019, 11:32 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

ezequielg requested review of this revision.Oct 11 2019, 11:32 AM

Harbormaster completed remote builds in B17561: Diff 67696.Oct 11 2019, 11:32 AM

garg added a reviewer: KWin.Oct 11 2019, 2:45 PM

garg added a subscriber: garg.

Given you have it as 3 commits locally, can you upload it as 3 phab requests.
Phabricator always squashes them. It's a bit tricky to review a bug fix and a POC in one.

Revision Contents
Changeset List

			Path	Packages
M			plugins/platforms/drm/drm_backend.h (1 line)
M			plugins/platforms/drm/drm_backend.cpp (32 lines)
M			plugins/platforms/drm/drm_buffer.h (2 lines)
M			plugins/platforms/drm/drm_buffer.cpp (32 lines)
M			plugins/platforms/drm/drm_output.h (5 lines)
M			plugins/platforms/drm/drm_output.cpp (67 lines)

Commit	Tree	Parents	Author	Summary	Date
39d022839709	5b89a4812b49	c407dc01b6e3	Ezequiel Garcia	[platforms/drm] RFC/PoC: Support hardware cursors using DRM atomic API (Show More…)	Oct 7 2019, 7:06 PM
c407dc01b6e3	ff99617635ae	ae2653d9024e	Ezequiel Garcia	[platforms/drm] Allow to specify to dumb buffers' format (Show More…)	Oct 7 2019, 7:04 PM
ae2653d9024e	c8bff5291bda	10ace126be21	Ezequiel Garcia	[platforms/drm] Fix hardware cursor initialization (Show More…)	Oct 7 2019, 7:02 PM